SSH key check is too strict

Keys with BEGIN OPENSSH PRIVATE KEY are also valid Reported on mailing list: https://groups.google.com/g/jenkinsci-users/c/GwDegE_BdMg
jenkinsci · Apr 13, 2021 · c64692f · c64692f
1 parent c25c122
commit c64692f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/hudson/plugins/ec2/EC2Cloud.java b/src/main/java/hudson/plugins/ec2/EC2Cloud.java
@@ -1102,9 +1102,11 @@ public FormValidation doCheckSshKeysCredentialsId(@QueryParameter String value)
             BufferedReader br = new BufferedReader(new StringReader(privateKey));
             String line;
             while ((line = br.readLine()) != null) {
-                if (line.equals("-----BEGIN RSA PRIVATE KEY-----"))
+                if (line.equals("-----BEGIN RSA PRIVATE KEY-----") ||
+                        line.equals("-----BEGIN OPENSSH PRIVATE KEY-----"))
                     hasStart = true;
-                if (line.equals("-----END RSA PRIVATE KEY-----"))
+                if (line.equals("-----END RSA PRIVATE KEY-----") ||
+                        line.equals("-----END OPENSSH PRIVATE KEY-----"))
                     hasEnd = true;
             }
             if (!hasStart)