Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use filter query when describing instances #356

Merged
merged 8 commits into from
Oct 17, 2019
Merged

Use filter query when describing instances #356

merged 8 commits into from
Oct 17, 2019

Conversation

res0nance
Copy link
Contributor

  • Get the API to do the filtering instead of doing it ourselves

jvz
jvz approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement so far.

@res0nance res0nance marked this pull request as ready for review May 30, 2019 01:34
@res0nance
Copy link
Contributor Author

@jvz I think I'm done with this just turning it into the equivalent call letting the aws api deal with as much of the filtering as possible

@jvz
Copy link
Member

jvz commented Jul 10, 2019

Can you either add a test or describe how to manually test this?

@res0nance
Copy link
Contributor Author

Behaviour doesn't change it has the exact behaviour as before as for automated testing we need a way to mock the aws api for that

@res0nance
Copy link
Contributor Author

@thoulen Can you take a look at this? This should help reduce the amount of data we pull from aws api and offload some of the filtering logic back to aws.

@thoulen
Copy link
Contributor

thoulen commented Aug 24, 2019

I am testing the patch

@res0nance
Copy link
Contributor Author

Added a fix to take care of a possible miscount when nexttoken is available

@res0nance res0nance added the enhancement Feature additions or enhancements label Sep 4, 2019
@res0nance res0nance closed this Sep 25, 2019
@res0nance res0nance reopened this Sep 25, 2019
@res0nance res0nance closed this Sep 26, 2019
@res0nance res0nance reopened this Sep 26, 2019
@res0nance res0nance closed this Sep 27, 2019
@res0nance res0nance reopened this Sep 27, 2019
@res0nance res0nance requested a review from thoulen September 27, 2019 14:14
@res0nance
Copy link
Contributor Author

This PR also includes a bugfix where instance counting will be wrong if there are more than 1000 instances because we ignore the next token

@res0nance res0nance closed this Oct 3, 2019
@res0nance res0nance reopened this Oct 3, 2019
@res0nance
Copy link
Contributor Author

Tested this and my instance caps are still properly respected so I'm merging it.

@res0nance res0nance merged commit bb03069 into jenkinsci:master Oct 17, 2019
@res0nance res0nance deleted the filter-query branch October 17, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcojfernandez fcojfernandez fcojfernandez approved these changes

@jvz jvz jvz approved these changes

@thoulen thoulen Awaiting requested review from thoulen

Assignees
No one assigned
Labels
enhancement Feature additions or enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@res0nance @jvz @thoulen @fcojfernandez