Use non-deprecated code and remove unused imports #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm done with this, finally cleaned up most of the deprecated code |
res0nance
changed the title
jvz
reviewed
Aug 21, 2019
| if (useHTTPS) { | ||
| try { | ||
| SSLConnectionSocketFactory sslConnectionFactory = new SSLConnectionSocketFactory( | ||
| new SSLContextBuilder().loadTrustMaterial(null, new TrustSelfSignedStrategy()).build(), |
There was a problem hiding this comment.
Now I'm assuming this is a pure refactoring here, but this is not the greatest idea. There should probably be an admin-controlled config setting to disable hostname verification and whatnot.
There was a problem hiding this comment.
This is pure refactoring, we should enhance this from a security perspective outside of this PR.
jvz
approved these changes
Aug 22, 2019
|
I'll merge this tomorrow if no issues. |
jvz
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all the deprecated code particularly in the WinRM bits