Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace base64 implementation with java provided one #391

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Replace base64 implementation with java provided one #391

merged 1 commit into from
Aug 23, 2019

Conversation

res0nance
Copy link
Contributor

Standardize to a single implementation.

jvz
jvz approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Test failures seem infrastructure related.

@res0nance
Copy link
Contributor Author

Retrigger CI

@res0nance res0nance closed this Aug 23, 2019
@res0nance res0nance reopened this Aug 23, 2019
@jvz jvz merged commit 62938ca into jenkinsci:master Aug 23, 2019
@res0nance res0nance deleted the base64 branch August 26, 2019 02:01
@res0nance res0nance added the chore label Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvz jvz jvz approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
2 participants
@res0nance @jvz