[JENKINS-59562] Always use network interface for subnet #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvz
approved these changes
Sep 27, 2019
|
I can test this manually on monday, I'm hoping the issue reporter would test this as well as I have updated the ticket. |
|
Apparently security groups must be specified the same way as well. Changed that bit too |
|
CI failures are due to a windows deletion issue |
varyvol
approved these changes
Sep 30, 2019
fcojfernandez
approved these changes
Sep 30, 2019
|
Hey, will 1.46.1 be released in the plugin repository so we can have it working? |
|
@kern3l it should be available already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you specify network interfaces you must not specify the subnet or security groups on the instance level.
Essentially what happens is when you specify a network interface all networking related configurations must be on the interface specification or the ec2 api will return an error.