Add Per-AMI Spare Instance parameter #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughsaunders
force-pushed
the
conjurinc-ops-401
branch
2 times, most recently
from
e3fb940
to
1fcdb8c
Compare
res0nance
approved these changes
Dec 2, 2019
hughsaunders
force-pushed
the
conjurinc-ops-401
branch
from
1fcdb8c
to
0d316c0
Compare
hughsaunders
force-pushed
the
conjurinc-ops-401
branch
from
0d316c0
to
24579b6
Compare
hughsaunders
force-pushed
the
conjurinc-ops-401
branch
from
24579b6
to
cc2a0d6
Compare
|
Hi @res0nance, thanks for your review, I've fixed the ci issues, mind having another look? |
res0nance
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
Looks good to me pinging other reviewers
FYI: @erikhakansson can't request a review from you so pinging you
|
LGTM! Great idea that I'll definitely use at work. @res0nance is that because I'm not a member of the organisation? |
jvz
reviewed
Jan 9, 2020
Will Do |
Currently there is a parameter for minimum number of instances, if you set this to n, there will always be at least n instances. This PR adds minimum spare instances, if you set this to n, there will always be n unsused instances waiting for new builds (unless the instance cap is reached). Related: conjurinc/ops#401
hughsaunders
force-pushed
the
conjurinc-ops-401
branch
from
712d5ef
to
d57a278
Compare
|
Added basic test |
jvz
approved these changes
Jan 13, 2020
|
Please for the love of JCasC and the next person touching this, split the data bound constructor to only be MANDATORY fields and everything else should use data bound setters. https://issues.jenkins-ci.org/browse/JENKINS-57513 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a parameter for minimum number of instances for an AMI,
if you set it to n, there will always be at least n instances.
This PR adds minimum spare instances, if you set this to n, there will
always be n unsused instances waiting for new builds (unless the
instance cap is reached). This prevents new builds from having to wait
for provisioning, while also meaning that you don't need to set a high
absolute minimum.
Related: conjurinc/ops#401