Update EC2Slave and SlaveTemplate help text #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove obsolete help text for help-stopOnTerminate.html. EC2 is now billed per second (min 60 seconds), so short stop timeouts are no longer counterproductive.
|
Windows is still billed by the hour so the text should be amended with that information |
res0nance
requested changes
Dec 2, 2019
- Add back short stop time warning with the clarification that it only affects Windows agents
res0nance
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove obsolete help text for help-stopOnTerminate.html. EC2 is now billed per second (min 60 seconds), so short stop timeouts are no longer counterproductive.Add clarification that short stop timeouts only matter for windows agents.