Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-59633] delete new lines in encrypted windows password #418

Merged
merged 1 commit into from
Dec 4, 2019
Merged

[JENKINS-59633] delete new lines in encrypted windows password #418

merged 1 commit into from
Dec 4, 2019

Conversation

rpionke
Copy link
Member

@rpionke rpionke commented Dec 3, 2019

@res0nance res0nance changed the title JENKINS-59633 delete new lines in encrypted windows password [JENKINS-59633] delete new lines in encrypted windows password Dec 4, 2019
jvz
jvz approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the test, too!

@res0nance res0nance merged commit 395bfc8 into jenkinsci:master Dec 4, 2019
@timbrown5
Copy link

timbrown5 commented Dec 13, 2019 •
edited
Loading

Is there any plan to release this? Due to this (and other bugs in 1.44-1.46) I have been forced to trying to downgrade to 1.43 and finding that is incompatible with my issues with Config as Code settings.

Update:
Actually I can't use 1.43 with my Jenkins version (I get an error after specifing it in plugins.txt) So I can't use recently built Windows agents (have to use ones before Windows changed their behaviour).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@res0nance res0nance res0nance approved these changes

@jvz jvz jvz approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rpionke @timbrown5 @jvz @res0nance