[JENKINS-51316] Remove generateKey functionality #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvz
approved these changes
Jan 16, 2020
Co-Authored-By: Matt Sicker <boards@gmail.com>
res0nance
approved these changes
Jan 17, 2020
Co-Authored-By: Francisco Fernández <31063239+fcojfernandez@users.noreply.github.com>
Co-Authored-By: Francisco Fernández <31063239+fcojfernandez@users.noreply.github.com>
fcojfernandez
approved these changes
Jan 17, 2020
varyvol
approved these changes
Jan 17, 2020
|
@res0nance @jvz is fine for you if we release a new version containing this change and hence without a non-working feature? |
|
Fine with me. |
|
Perfectly alright with me
…On Fri, 17 Jan 2020, 10:57 PM Matt Sicker, ***@***.***> wrote:
Fine with me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#426?email_source=notifications&email_token=AHPIYTG3EXP6V4MOONRJIV3Q6HBL3A5CNFSM4KHWXS32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJH5YXA#issuecomment-575659100>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHPIYTDPTZ4V6ZF4UQMIN4TQ6HBL3ANCNFSM4KHWXS3Q>
.
|
|
I will release it on Monday morning then! thanks everyone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-51316 for the reasons behind this change.