Use Spot Pagination API #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test to this? |
|
I've tested my change locally and everything works. Can you show me an example of an existing test so I can model mine similarly? |
bwagner5
force-pushed
the
spot-pagination
branch
from
7d9846d
to
77cd723
Compare
|
added a unit test. |
res0nance
approved these changes
Apr 23, 2020
thoulen
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spot API is unbounded if MaxResults is not specified which can cause long waits and possible connection timeouts if an account has a lot of spot instances. This commit specifies the MaxResults parameter to the spot-describe-instances-request API to trigger the pagination response and wraps the code in a pagination do-while loop.
I tested this on a clean jenkins install with 105 spot instances. The response properly paged through the additional 5 instances in the second page of results.