Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Groovy script: fix UnixData and AmazonEC2Cloud #451

Merged

Conversation

vazhnov
Copy link
Contributor

@vazhnov vazhnov commented Apr 26, 2020

Here is a fix for the example "Configure plugin via Groovy script".

Error # 1:

groovy.lang.GroovyRuntimeException: Could not find matching constructor for: hudson.plugins.ec2.UnixData(null, null, null)

Error # 2:

groovy.lang.GroovyRuntimeException: Could not find matching constructor for: hudson.plugins.ec2.AmazonEC2Cloud(java.lang.String, java.lang.Boolean, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.util.ArrayList)

P.S.: I don't know Java, so please check syntax and logic, maybe I did wrong fix. But Jenkins script console works fine with this fix.

@vazhnov
Copy link
Contributor Author

vazhnov commented Apr 26, 2020

There are other updates to README: https://github.com/vazhnov/ec2-plugin/tree/README_improvments , I'm going to create pull request next after this one.

@thoulen thoulen requested review from thoulen and res0nance and removed request for thoulen April 27, 2020 07:47
@thoulen thoulen added the bugfix label Apr 27, 2020
@thoulen thoulen added this to the 1.51 milestone Apr 27, 2020
@res0nance res0nance added documentation Documentation update and removed bugfix labels Apr 27, 2020
@bschaefer99
Copy link

The tag configuration needs to be updated, as well. The current example only shows one tag, and it doesn't save properly. Trying to launch the slave will cause a jenkins error.

@vazhnov
Copy link
Contributor Author

vazhnov commented May 7, 2020

@bschaefer99 , let's merge this one and maybe later I can create patch for that you pointed — right now I can't check slave node launch.

@vazhnov
Copy link
Contributor Author

vazhnov commented Jun 22, 2020

Guys, let's merge this one and then merge next improvements https://github.com/vazhnov/ec2-plugin/tree/README_improvments while here is no conflicts in branches.

@res0nance res0nance merged commit e43e315 into jenkinsci:master Jun 22, 2020
@vazhnov
Copy link
Contributor Author

vazhnov commented Jun 23, 2020

@res0nance , thank you!
I've created next pull request: #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants