Fix CI Errors #454
Merged
Fix CI Errors #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2020 14:11
|
Includes a fix for testing on newer versions of jenkins due to to jenkinsci/jenkins#4339 rearranging the UI |
fcojfernandez
approved these changes
May 6, 2020
Comment on lines
+98
to
+102
| if (Jenkins.getVersion().isNewerThanOrEqualTo(new VersionNumber("2.205"))) { | ||
| return r.createWebClient().goTo("configureClouds").getFormByName("config"); | ||
| } else { | ||
| return r.createWebClient().goTo("configure").getFormByName("config"); | ||
| } |
There was a problem hiding this comment.
Its the rework to the clouds section so I added this code to be forwards compatible
There was a problem hiding this comment.
yes I've checked during my review because I wanted to be sure of understanding it. But it shocked me at a first glance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to fix the build on ci.jenkins.io