JENKINS-62212 Add filter to periodic EC2 connection polling #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamur2
commented
May 7, 2020
| @@ -1051,7 +1051,10 @@ protected void doRun() throws IOException { | |||
| LOGGER.finer(() -> "Checking EC2 Connection on: " + ec2_cloud.getDisplayName()); | |||
| try { | |||
| if(ec2_cloud.connection != null) { | |||
| ec2_cloud.connection.describeInstances(); | |||
| List<Filter> filters = new ArrayList<>(); | |||
| filters.add(new Filter("tag-key").withValues("bogus-EC2ConnectionKeepalive")); | |||
There was a problem hiding this comment.
I don't know if there's a more idiomatic way to craft a filter that returns few/no instances, while also not triggering an AmazonClientException. This was just the first thing that came to mind.
It appears the response from this request is discarded, and the request is made only to validate we still have a good connection to AWS. This prevents the connection polling from returning _all_ ec2 instances in the AWS account, using up AWS API quotas (which take result size into account for API quota tracking purposes).
res0nance
approved these changes
May 10, 2020
|
Is there anything I can do to help verify this? |
|
any traction on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the response from this request is discarded, and the request
is made only to validate we still have a good connection to AWS.
This prevents the connection polling from returning all ec2 instances
in the AWS account, using up AWS API quotas (which take result size into
account for API quota tracking purposes).
We are running a semi-degenerate setup with ~50 instances in a single AWS account, all of which make this unfiltered request every minute, and have been getting API throttled. My rough understanding is that this is just a health check and we don't actually need the whole query result, and we've been running one master with this patch with no ill effects so far, but it's entirely possible I'm misinterpreting the purpose of this request.