Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-62090] Specify SGs only on 1 part of request #458

Merged
merged 2 commits into from
May 12, 2020
Merged

[JENKINS-62090] Specify SGs only on 1 part of request #458

merged 2 commits into from
May 12, 2020

Conversation

res0nance
Copy link
Contributor

Signed-off-by: Raihaan Shouhell raihaan.shouhell@autodesk.com

Specify setting on only 1 part of the request amends #447

CC: @jzyeezy

Specify SGs only on 1 part of request
658b331 
Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>
@res0nance res0nance closed this May 8, 2020
@res0nance res0nance reopened this May 8, 2020
MRamonLeon
MRamonLeon approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@MRamonLeon MRamonLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkEWaite it may solve the failure you had when you updated to 1.50.2

@MRamonLeon
Copy link
Contributor

The error seems genuine:

[2020-05-08T03:36:54.131Z] [WARNING] Rule 5: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
[2020-05-08T03:36:54.131Z] Failed while enforcing RequireUpperBoundDeps. The error(s) are [
[2020-05-08T03:36:54.131Z] Require upper bound dependencies error for org.apache.commons:commons-compress:1.16.1 paths to dependency are:
[2020-05-08T03:36:54.131Z] +-org.jenkins-ci.plugins:ec2:1.51-rc1147.658b331984db
[2020-05-08T03:36:54.131Z]   +-org.testcontainers:testcontainers:1.8.3
[2020-05-08T03:36:54.131Z]     +-org.apache.commons:commons-compress:1.16.1
[2020-05-08T03:36:54.131Z] and
[2020-05-08T03:36:54.131Z] +-org.jenkins-ci.plugins:ec2:1.51-rc1147.658b331984db
[2020-05-08T03:36:54.131Z]   +-org.jenkins-ci.main:jenkins-core:2.222.3
[2020-05-08T03:36:54.131Z]     +-org.apache.commons:commons-compress:1.19

I introduced testcontainers to test connecting with certificates and so on

@res0nance
Copy link
Contributor Author

The error seems genuine:

[2020-05-08T03:36:54.131Z] [WARNING] Rule 5: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
[2020-05-08T03:36:54.131Z] Failed while enforcing RequireUpperBoundDeps. The error(s) are [
[2020-05-08T03:36:54.131Z] Require upper bound dependencies error for org.apache.commons:commons-compress:1.16.1 paths to dependency are:
[2020-05-08T03:36:54.131Z] +-org.jenkins-ci.plugins:ec2:1.51-rc1147.658b331984db
[2020-05-08T03:36:54.131Z]   +-org.testcontainers:testcontainers:1.8.3
[2020-05-08T03:36:54.131Z]     +-org.apache.commons:commons-compress:1.16.1
[2020-05-08T03:36:54.131Z] and
[2020-05-08T03:36:54.131Z] +-org.jenkins-ci.plugins:ec2:1.51-rc1147.658b331984db
[2020-05-08T03:36:54.131Z]   +-org.jenkins-ci.main:jenkins-core:2.222.3
[2020-05-08T03:36:54.131Z]     +-org.apache.commons:commons-compress:1.19

I introduced testcontainers to test connecting with certificates and so on

Yeah i just fixed it in master by excluding commons-compress from testcontainers

@res0nance res0nance merged commit 3518739 into master May 12, 2020
@res0nance res0nance deleted the JENKINS-62090 branch May 12, 2020 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvz jvz jvz approved these changes

@MRamonLeon MRamonLeon MRamonLeon approved these changes

@fcojfernandez fcojfernandez fcojfernandez approved these changes

@thoulen thoulen Awaiting requested review from thoulen

Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
No milestone
4 participants
@res0nance @MRamonLeon @jvz @fcojfernandez