Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WinRM Connection Pooling implementation #473

Merged
merged 3 commits into from
Nov 5, 2020
Merged

WinRM Connection Pooling implementation #473

merged 3 commits into from
Nov 5, 2020

Conversation

narayanan
Copy link
Contributor

We noticed that HTTPClient used for WinRM connections are not pooled. Updated the client to use a connection pool manager.

Tested the changes in our internal jenkins instances.

@narayanan
Copy link
Contributor Author

Just noticed this is very similar to other PR which is in draft: #469

@usairman82 usairman82 mentioned this pull request Jun 1, 2020
Closed
@res0nance
Copy link
Contributor

@narayanan Could you rebase this?

@narayanan
Copy link
Contributor Author

@res0nance Resolved conflicts

@res0nance res0nance added the enhancement Feature additions or enhancements label Nov 5, 2020
@res0nance res0nance merged commit f21a54f into jenkinsci:master Nov 5, 2020
@narayanan narayanan deleted the winrm-connection-pool branch November 5, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slide slide slide left review comments

@res0nance res0nance res0nance approved these changes

Assignees
No one assigned
Labels
enhancement Feature additions or enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narayanan @res0nance @slide