[JENKINS-62489] Support m6g ec2 instances #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My keyboard went bananas and hit enter before I finished the title & description 🤦 |
schottsfired
changed the title
kerogers-cloudbees
approved these changes
Jul 21, 2020
|
Does this also add support for c5a instance? |
|
Hi @xsacha, it should, since c5a instances are in |
fcojfernandez
approved these changes
Jul 31, 2020
batmat
reviewed
Jul 31, 2020
| <java.level>8</java.level> | ||
| <jcasc.version>1.36</jcasc.version> | ||
| <aws-java-sdk.version>1.11.723</aws-java-sdk.version> | ||
| <aws-java-sdk.version>1.11.821</aws-java-sdk.version> |
There was a problem hiding this comment.
After a second thought, I realize: this is going to force this plugin to require this release with new additions, which is good.
But this was not strictly necessary for a Jenkins instance to be able to see the new types: one would just have to make sure to update to the latest aws-java-sdk Jenkins plugin (i.e. 1.11.821+) right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up https://github.com/jenkinsci/aws-java-sdk-plugin/releases/tag/aws-java-sdk-1.11.821