Test to validate the EC2Cloud private key migration #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varyvol
changed the title
MRamonLeon
reviewed
Sep 18, 2020
| public JenkinsRule r = new JenkinsRule(); | ||
|
|
||
| @Test | ||
| @LocalData |
There was a problem hiding this comment.
Could you add some comment explaining that the local data is from a previous version of EC2 to show it clear the migration works? Or maybe in the config.xml you can add a comment noticing the privateKey is the actual key and not a credential and it works.
|
I don't pretend this to supersede the original PR, only to demonstrate how to use LocalData to perform the related testing. |
MRamonLeon
approved these changes
Sep 18, 2020
res0nance
approved these changes
Sep 18, 2020
|
This breaks the plugin. We ended up rolling back. |
|
@CptPlastic this only adds a test, so I guess you'll be referring to a previous PR. Which version did you update to? |
|
this is raised as https://issues.jenkins-ci.org/browse/JENKINS-63707 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to #498 an automated test validating the migration for an EC2 cloud is correctly done.
@MRamonLeon @djesionek