Use SSHUserPrivateKey instead of BasicSSHUserPrivateKey

[chriskilding]

Use the general SSHUserPrivateKey type when looking up SSH credentials instead of the BasicSSHUserPrivateKey concrete subtype. This will allow the plugin to use any compatible SSH key, not just BasicSSHUserPrivateKey instances.

Fixes JENKINS-63986

[chriskilding]

Can't proceed on this until we have a way to test the change. What are the relevant tests to modify?

[chriskilding]

@res0nance I believe you're one of the maintainers - would you be able to advise where the tests are for using SSH keys from the credentials API, and thus which tests I should modify to ensure this fix works?

[res0nance]

Hey Chris, just saw this, give me a bit to double check this bit.

[res0nance]

Hey Chris i added a test in #523 which should help you out

[chriskilding]

I've pinged the reporter to ask if he'd like to test a build of the fix in his local Jenkins

[chriskilding]

Mark has confirmed that it works.

He also said it might be worth putting out a notice of a breaking change for JCasC, since we have to change the config or our clouds will be unable to start.

[johnl2323]

Chris, We ran into this issue using the AWS Secrets Manager Credential Provider plugin as the source of our credentials. We can test this if you can provide a link to the plugin version to install. johnl

…

On Wed, Oct 28, 2020 at 11:16 AM Chris Kilding ***@***.***> wrote: I've pinged the reporter to ask if he'd like to test a build of the fix in his local Jenkins — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#520 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACVSUPI32L2VB7UXMF7TOS3SNA7UXANCNFSM4S3HEJDQ> .

[chriskilding]

The plugin build with the fix can be found at:

https://ci.jenkins.io/job/Plugins/job/ec2-plugin/job/PR-520/5/artifact/org/jenkins-ci/plugins/ec2/1.54-rc1218.bd9a8dd69948/ec2-1.54-rc1218.bd9a8dd69948.hpi

We've had a confirmation that it works so it should be good to merge, but if you need the fix in the meantime, here it is :)

[johnl2323]

I can confirm that this PR fixes our issue and allows access to the AWS secrets manager credentials via the secrets manager credential provider plugin.

…

On Wed, Oct 28, 2020 at 5:52 PM Chris Kilding ***@***.***> wrote: The plugin build with the fix can be found at: https://ci.jenkins.io/job/Plugins/job/ec2-plugin/job/PR-520/5/artifact/org/jenkins-ci/plugins/ec2/1.54-rc1218.bd9a8dd69948/ec2-1.54-rc1218.bd9a8dd69948.hpi We've had a confirmation that it works so it should be good to merge, but if you need the fix in the meantime, here it is :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#520 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACVSUPPXKILNWJ6YC4WTK5DSNCODJANCNFSM4S3HEJDQ> .