[JENKINS-62908] Remove table row for embedded descriptor class #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
res0nance
approved these changes
Dec 7, 2020
fcojfernandez
approved these changes
Dec 9, 2020
MRamonLeon
approved these changes
Dec 11, 2020
jtnord
reviewed
Dec 11, 2020
| <tr><td><input type="hidden" name="stapler-class" value="${instance.descriptor.clazz.name}"/></td></tr> | ||
| <st:include from="${instance.descriptor}" page="${instance.descriptor.configPage}" /> | ||
| </f:dropdownListBlock> | ||
| <f:dropdownListBlock value="0" title="${instance.amiType.descriptor.displayName}" staperClass="${instance.descriptor.clazz.name}" selected="true"> |
There was a problem hiding this comment.
would form:dropdownDescriptorSelector do all of this in one shot?
code
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inspiration came from https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/lib/form/dropdownListBlock.jelly#L38.
The problem was the row just to have a hidden input to specify the
stapler-class, when in fact thedropdownListBlockhas an attribute to store this value.