Don't fetch instance data on node creation #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new node is provisioned from EC2, the instance data should be lazily fetched in order to avoid generating network traffic in the NodeProvisioner thread. All the getters for the attributes updated by fetchLiveInstanceData call it first to update if need be, so there's no need to be eager here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new node is provisioned from EC2, the instance data should be
lazily fetched in order to avoid generating network traffic in the
NodeProvisioner thread. All the getters for the attributes updated by
fetchLiveInstanceData call it first to update if need be, so there's no
need to be eager here.