-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Mac AMI Type support to launch mac1.metal instances by ec2-plugin #585
Conversation
…into macSupport
@res0nance can you label it as enhancement. |
I do not understand this change, the new launcher simply looks like a copy of UnixLauncher so why can't we use that instead? |
@res0nance installation of java would be different in case of OSX. |
I could use System.getProperty("os.name") and added check in unix launcher to solve it but kept a new class and other files separate for mac, in case we want to add more functionality related to mac. let me know your thoughts, i can add system property changes and have another PR. |
@res0nance In future if there is a drift having different path(linux and mac) is helpful |
I think the change is ok but i lack the infrastructure to test this properly. Have you tested these changes? |
yes i have validated this changes. |
@res0nance who's responsible for version releases? |
Technically any maintainer can release it |
Is there any hopes of that happening soon after the tests on the |
Is there any documentation on how to config this? Especially the dedicated host part. Do we need to first reserved a host or the plugin will do it for us? Thanks |
This plugin won't reserve the host. You will have to reserve the host. This plugin can help you to launch the mac1.metal instance on the dedicated host. |
in https://docs.aws.amazon.com/powershell/latest/reference/items/New-EC2Instance.html I see this But with option in the plugin only have Tenancy choice, where to pass the host ID? |
You have to turn on the Instance auto-placement – Enable auto-placement to allow the host to accept untargeted instance launches that match its host configuration. By default, it will not be enabled. |
@ykhandelwal913 I am new to AWS so can you point me to where to turn on the instance auto-placement? Is it in the AWS panel? Thanks |
@a-pikachu sorry for the delay in reply. Either when you are reserving the instance you can pass the parameter like |
@ykhandelwal913 thank you, I have it resolved now by enabling auto-placement. |
Adding following feature as part of the PR
This PR has a dependency on Add Support for Host Tenancy Option #492 as mac1.metal instances need HostTenancy.