Issue 9065 #6
Closed
Issue 9065 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce cap has been hit.
|
Thanks. Merged toward 1.11. I've also added you as a committer so that you can directly push to the repository for simple changes like this. Thanks! |
csilvers
added a commit
to Khan/ec2-plugin
that referenced
this pull request
Oct 20, 2014
Summary: Sometimes slave.jar dies due to an OOM error or the like. In those cases, make it automatically restart. Jenkins doesn't notice that slaves are dead in order to restart it themselves. Test Plan: Fingers crossed. I'll install this on jenkins, terminate all the jenkins-slave machines on ec2, and run make-allcheck, and make sure the slaves start up properly. I don't know what com.trilead.ssh2.Connection.execCommand does, but it looks like it just runs the given command in the shell, based on code example jenkinsci#6 at http://www.programcreek.com/java-api-examples/index.php?api=com.trilead.ssh2.Session >>> sess.execCommand("uname -a && date && uptime && who"); Reviewers: jlfwong Reviewed By: jlfwong Subscribers: chris Differential Revision: http://phabricator.khanacademy.org/D14010
daniel-beck
pushed a commit
that referenced
this pull request
May 6, 2020
BindingStep fixes enabled by Workflow 1.5
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This fixes http://issues.jenkins-ci.org/browse/JENKINS-9065 by adding a log statement when the instance cap is the reason for not launching an instance.
This is my first time using git, github or developing in Java, so it's also a bit of a test for me, so please let me know if I did anything wrong.
Cheers,
Michael