Fill credentials from current context instead of just Jenkins singleton #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
res0nance
approved these changes
Apr 23, 2021
MRamonLeon
reviewed
May 4, 2021
| @@ -1153,12 +1154,12 @@ public FormValidation doCheckSshKeysCredentialsId(@QueryParameter String value) | |||
| * @throws IOException | |||
| * @throws ServletException | |||
| */ | |||
| protected FormValidation doTestConnection(URL ec2endpoint, boolean useInstanceProfileForCredentials, String credentialsId, String sshKeysCredentialsId, String roleArn, String roleSessionName, String region) | |||
| protected FormValidation doTestConnection(@AncestorInPath ItemGroup context, URL ec2endpoint, boolean useInstanceProfileForCredentials, String credentialsId, String sshKeysCredentialsId, String roleArn, String roleSessionName, String region) | |||
There was a problem hiding this comment.
Keeping the former method, without the context, to keep the compatibility would be good. Some subclasses may rely on the old signature.
There was a problem hiding this comment.
Since this is a method expected to be called from jellies, it shouldn't break anything. So not a big deal to deserve a fix PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing this as this is useful in CloudBees products where Cloud implementation can be configured within Folders within folders, then pushed connected Jenkins instance. Similar feature were added to for example the kubernetes plugin: jenkinsci/kubernetes-plugin@00ca6a8
I have added a test to validate that this does not impact the current functionalities.