[JENKINS-64571] Fall back to on demand provisioning when spot quota exceeded and option set #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
res0nance
reviewed
Apr 29, 2021
| RequestSpotInstancesResult reqResult; | ||
| try { | ||
| // Make the request for a new Spot instance | ||
| reqResult = ec2.requestSpotInstances(spotRequest); |
There was a problem hiding this comment.
There seems to be some logic below for something similar could the logic be merged instead of duplicated?
There was a problem hiding this comment.
The logic is not really duplicated. In this case the client would just throw an exception, while in SlaveTemplate.java:1405 the logic is based on the status of spots requests that were created successfully. (hence the need to cancel them before falling back to on demand)
res0nance
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue available at: https://issues.jenkins.io/browse/JENKINS-64571