Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-64738] Fixed reference to get the amiType class name #612

Merged
merged 1 commit into from
May 21, 2021

Conversation

TheImplementer
Copy link
Contributor

Turns out the typo fixed in 608 wasn't the only thing wrong. The instance var is only reassigned inside the dropdownListBlock element, so instance.amiType should be used in the staplerClass attribute instead.

The fix has been tested manually and now works as expected.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@TheImplementer
Copy link
Contributor Author

Anyone who can review this? @res0nance maybe? It would be good to have it in the next release.

@res0nance res0nance merged commit ae002c0 into jenkinsci:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants