Add required library to project configuration #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update minimum core version and bom
MRamonLeon
reviewed
May 20, 2021
| <scope>import</scope> | ||
| <type>pom</type> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>joda-time</groupId> | ||
| <artifactId>joda-time</artifactId> |
There was a problem hiding this comment.
why is it needed now and not before?
There was a problem hiding this comment.
Because of the version used in two different dependencies which are using different versions.
And it is a dependencyManagement not a direct dependency.
MRamonLeon
approved these changes
May 20, 2021
res0nance
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update minimum core version and bom
Since jenkinsci/jenkins#5047 was merged in Jenkins Core, the library
libzfswas removed. This library is required in this plugin but was not properly described.