-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-64569] Add support for EBS Throughput parameter #621
Conversation
Hey I noticed the tests were not getting run in CI and enabled them but accidentally broke this PR |
99b3de8
to
fcd0b4c
Compare
Thanks @res0nance! Just rebased and all the device mapping tests (including the new one) passed locally, so we'll see what happens in CI :) One thing I was lightly concerned about is that the |
Is there any action left on my end for this to get merged? This feature is mostly a nice-to-have for us, so I'm not in an enormous rush, but also don't want to be blocking :) |
No, I was waiting for CI to finish |
Awesome, thanks again for your help with this! |
There is a missing change in the documentation related with the throughput value (needed using gp3 type volumes) https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/resources/hudson/plugins/ec2/SlaveTemplate/help-customDeviceMapping.html#L32 Also, an example with encrypted disabled could be useful. Currently I'm not sure if it should be |
Mmm, it seems that I just need to set the encrypted section empty to disable encryption according to this code. So, |
Closes https://issues.jenkins.io/browse/JENKINS-64569 by adding the
throughput
param to the end of the parser for the colon separated string. Based on other existing tests which have fewer separators than options, this should be entirely backwards compatible with existing block device config strings.I've written a simple test, but I'm having issues getting the
util
tests to run both locally and in CI. It seems like maybe they aren't getting picked up by the Maven project?