Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PowerMock #771

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Remove PowerMock #771

merged 1 commit into from
Aug 24, 2022

Conversation

basil
Copy link
Member

@basil basil commented Aug 23, 2022

Without this PR, running the test suite with jenkins.version set to the latest weekly fails with:

java.lang.IllegalArgumentException: org.kohsuke.stapler.ClassLoaderValue$X referenced from a method is not visible from class loader
        at java.base/java.lang.reflect.Proxy$ProxyBuilder.ensureVisible(Proxy.java:858)
        at java.base/java.lang.reflect.Proxy$ProxyBuilder.validateProxyInterfaces(Proxy.java:681)
        at java.base/java.lang.reflect.Proxy$ProxyBuilder.<init>(Proxy.java:627)
        at java.base/java.lang.reflect.Proxy$ProxyBuilder.<init>(Proxy.java:635)
        at java.base/java.lang.reflect.Proxy.lambda$getProxyConstructor$0(Proxy.java:415)
        at java.base/jdk.internal.loader.AbstractClassLoaderValue$Memoizer.get(AbstractClassLoaderValue.java:329)
        at java.base/jdk.internal.loader.AbstractClassLoaderValue.computeIfAbsent(AbstractClassLoaderValue.java:205)
        at java.base/java.lang.reflect.Proxy.getProxyConstructor(Proxy.java:413)
        at java.base/java.lang.reflect.Proxy.getProxyClass(Proxy.java:384)
        at org.kohsuke.stapler.ClassLoaderValue.get(ClassLoaderValue.java:55)
        at org.kohsuke.stapler.MetaClassLoader.get(MetaClassLoader.java:53)
        at org.kohsuke.stapler.MetaClassLoader.<init>(MetaClassLoader.java:46)
        at org.jvnet.hudson.test.JenkinsRule.<clinit>(JenkinsRule.java:2878)
        ... 30 more

CC @res0nance

@res0nance res0nance merged commit 8c746e8 into jenkinsci:master Aug 24, 2022
@basil basil deleted the powermock branch August 24, 2022 18:32
@basil
Copy link
Member Author

basil commented Aug 24, 2022

Thanks @res0nance! If you're willing to do a release of this, that would facilitate PCT testing of this plugin in preparation for the forthcoming 2.361.1 LTS release.

@res0nance
Copy link
Contributor

Thanks @res0nance! If you're willing to do a release of this, that would facilitate PCT testing of this plugin in preparation for the forthcoming 2.361.1 LTS release.

Done! Thanks for fixing this

@basil
Copy link
Member Author

basil commented Aug 25, 2022

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants