Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for mac2.metal instance type #816

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Adding support for mac2.metal instance type #816

merged 4 commits into from
Mar 8, 2023

Conversation

ykhandelwal913
Copy link
Contributor

@ykhandelwal913 ykhandelwal913 commented Mar 2, 2023 •
edited
Loading

In order to run mac2.metal using ec2 plugin, we need aarch64 java bundle. hence this request.

@ykhandelwal913
Copy link
Contributor Author

ykhandelwal913 commented Mar 2, 2023 •
edited
Loading

@res0nance Hope you are doing fine. Can you please invest some time reviewing this pull request.

@ykhandelwal913
Copy link
Contributor Author

@res0nance this is blocking us to validate the new mac instance. Can you please review this request.

@res0nance
Copy link
Contributor

res0nance commented Mar 4, 2023 via email

@ykhandelwal913
Copy link
Contributor Author

Sorry, I'm on vacation now. Should this pr not just download aarch64 for m1 macs? Why should we be concerned with rosetta? Cheers, Raihaan
…
On Sat, Mar 4, 2023, 3:37 PM yogesh khandelwal @.> wrote: @res0nance https://github.com/res0nance this is blocking us to validate the new mac instance. Can you please review this request. — Reply to this email directly, view it on GitHub <#816 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPIYTA7HAZ4VKPG4XUBY6LW2LWJ7ANCNFSM6AAAAAAVNYPUQY . You are receiving this because you were mentioned.Message ID: @.>

My bad. I used the aarch64 java now and updated the code as well

@res0nance
Copy link
Contributor

Since jenkins has dropped support for java 8 we probably should be installing java 11

@ykhandelwal913
Copy link
Contributor Author

Since jenkins has dropped support for java 8 we probably should be installing java 11

Done.

@ykhandelwal913
Copy link
Contributor Author

@res0nance Shall i update the java for x86 mac as well?

@ykhandelwal913
Copy link
Contributor Author

@recampbell can you please look?

@res0nance res0nance added the enhancement Feature additions or enhancements label Mar 7, 2023
@res0nance res0nance merged commit e4062f0 into jenkinsci:master Mar 8, 2023
@ykhandelwal913 ykhandelwal913 changed the title Adding rosetta terminal support for mac2.metal instance type Adding support for mac2.metal instance type Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@res0nance res0nance res0nance approved these changes

Assignees
No one assigned
Labels
enhancement Feature additions or enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ykhandelwal913 @res0nance @yogeshkhandelwal