Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for custom name for Eucalyptus. Also fixes roundtrip for ec2Endpoint and s3Endpoint #837

Merged
merged 1 commit into from
Apr 9, 2023
Merged

Adds support for custom name for Eucalyptus. Also fixes roundtrip for ec2Endpoint and s3Endpoint #837

merged 1 commit into from
Apr 9, 2023

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Apr 7, 2023 •
edited
Loading

Context: jenkinsci/jenkins#7658 is adding support for copying clouds. Clouds defining a fixed name should now support a name provided by the user.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe Vlatombe mentioned this pull request Apr 7, 2023
Merged
35 tasks
@res0nance res0nance merged commit 05cc875 into jenkinsci:master Apr 9, 2023
@Vlatombe Vlatombe deleted the eucalyptus-custom-name branch April 11, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@res0nance res0nance res0nance approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
2 participants
@Vlatombe @res0nance