Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call super method in EC2AbstractSlave#readResolve() #883

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Aug 31, 2023

EC2AbstractSlave overrides readResolve method but does not call super method. This means object initialization may be incomplete after coming back from a restart.

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options
Loading

EC2AbstractSlave overrides readResolve method but does not call super method.
This means object initialization may be incomplete after coming back
from a restart.
@Vlatombe Vlatombe changed the title Call super method in EC2AbstractSlave#readResolve() Call super method in EC2AbstractSlave#readResolve() Aug 31, 2023
@res0nance res0nance merged commit 9ea16c3 into jenkinsci:master Aug 31, 2023
16 checks passed
@Xyaren
Copy link

Xyaren commented Aug 31, 2023

Thanks you guys for the quick response on this issue ❤️
Could we get a hotfix release fixing this soon ?
This caused a service disruption if our jenkins today and probably will tomorrow if not fixed.

Thank you !

@res0nance
Copy link
Contributor

Thanks you guys for the quick response on this issue ❤️ Could we get a hotfix release fixing this soon ? This caused a service disruption if our jenkins today and probably will tomorrow if not fixed.

Thank you !

Hey, a new release has been made.

@Vlatombe Vlatombe deleted the readresolve-fix branch August 31, 2023 12:31
@Xyaren
Copy link

Xyaren commented Aug 31, 2023

Awesome! The version number looks a bit odd. Is that expected ?

@res0nance
Copy link
Contributor

Awesome! The version number looks a bit odd. Is that expected ?

Yes its fine. It should match what is in the Releases section of this repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants