Add additional accounts #166
Conversation
| smtpAuthUsername = nullify(req.getParameter("ext_mailer_smtp_username")); | ||
| smtpAuthPassword = Secret.fromString(nullify(req.getParameter("ext_mailer_smtp_password"))); | ||
| mailAccount.setSmtp_username(nullify(req.getParameter("ext_mailer_smtp_username"))); | ||
| mailAccount.setSmtp_password(nullify(req.getParameter("ext_mailer_smtp_password"))); |
There was a problem hiding this comment.
Why the loss of Secret.fromString
There was a problem hiding this comment.
because it makes inside of class
There was a problem hiding this comment.
That is by design and is required to store the password encrypted
There was a problem hiding this comment.
oh sorry missed it in the subclass
| this.smtpAuthPassword = Secret.fromString(Mailer.descriptor().getSmtpAuthPassword()); | ||
| this.smtpAuthUsername = Mailer.descriptor().getSmtpAuthUserName(); | ||
| mailAccount.setSmtp_username(Mailer.descriptor().getSmtpAuthUserName()); | ||
| mailAccount.setSmtp_password(Mailer.descriptor().getSmtpAuthPassword()); |
| return address; | ||
| } | ||
|
|
||
| public String getSmtp_host(){ |
There was a problem hiding this comment.
should really be getSmtpHost ie camelCase not a mix of camelCase and snake_case
|
also noticed there is no Use SMTP Authentication checkbox for additional accounts. |
|
can't believe I missed this before but also need to add some unit tests |
Kosterio
force-pushed
the
add_accounts
branch
from
9055510 to
f1f5dcb
Compare
|
sorry for rebase |
|
I'd like to see a test for create session if possible to assert that it used the right account, probably easiest to call it and then inspect the javamail properties on the returned session to see which server it used |
|
how are we going with this? I am waiting on this for the next release |
|
I don't know how to create mock session and test her. I had no free time to figure it out. |
|
You probably don't need to create a mock one I had a look and you should be able to call the function then get the properties off it and check it used the correct one |
|
@davidvanlaatum is it possible this broke the |
Added ability of additional smtp accounts and java mail parameters