Sketch test cases for JENKINS-63311 #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator changeable for tests
…n in ExtendedEmailPublisherDescriptor
|
This is a great idea, thanks for wanting to contribute. The big changes for JCasC caused some issues in various places, I don't foresee making such big changes again, but having test coverage would definitely be good. I'll review these |
Merged
|
Superseded by #217 |
|
Thank you. I really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would it be possible to add some test cases for JENKINS-63311? This issue broke authentication completely.
I'd prefer it if the authentication was covered by tests so I've added a few test cases. I'm sure they are incorrect in various ways because I don't have any experience contributing to Jenkins. Feel free to rewrite them to something more suitable.