Fix tests with Jenkins 2.395 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins 2.395 includes jenkinsci/jenkins#7661 that simplifies the names of the settings on the "Configure System" page. That simplification breaks email-ext tests in the Jenkins plugin bill of materials and any time they are run with Jenkins 2.395 or later. We can temporarily exclude the tests from the plugin bill of materials, but it is much better to have the tests pass. This pull request adapts the tests to the change so that they pass with the current weekly and past LTS releases. jenkinsci/bom#1857 shows the failing tests with Jenkins 2.395. The failures can also be seen with the command: ``` $ mvn clean -Dtest=ExtendedEmailPublisherDescriptorTest verify ```
MarkEWaite
added a commit
to jenkinsci/bom
that referenced
this pull request
Mar 15, 2023
Jenkins 2.395 simplified the page title but the plugin needs to be updated to test for the correct page title. jenkinsci/jenkins#7661 is the change in Jenkins core. jenkinsci/email-ext-plugin#431 provides more details on the issue
|
@slide could you review and merge this change when convenient for you? The test failure has been excluded from the plugin bill of materials pull request, but I'd much rather have the test updated than need to exclude the failure in the plugin BOM. |
github-actions bot
added a commit
to jenkinsci/bom
that referenced
this pull request
Mar 15, 2023
* chore: ran shell command "pwsh -NoProfile -File /home/runner/work/bom... ... /bom/updatecli/update-jenkins.ps1 weekly 2.395" Made with ❤️️ by updatecli * Exclude an email-ext test dependent on system config page title Jenkins 2.395 simplified the page title but the plugin needs to be updated to test for the correct page title. jenkinsci/jenkins#7661 is the change in Jenkins core. jenkinsci/email-ext-plugin#431 provides more details on the issue --------- Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
|
Released in 2.95. |
lemeurherve
pushed a commit
to lemeurherve/bom
that referenced
this pull request
Mar 31, 2023
* chore: ran shell command "pwsh -NoProfile -File /home/runner/work/bom... ... /bom/updatecli/update-jenkins.ps1 weekly 2.395" Made with ❤️️ by updatecli * Exclude an email-ext test dependent on system config page title Jenkins 2.395 simplified the page title but the plugin needs to be updated to test for the correct page title. jenkinsci/jenkins#7661 is the change in Jenkins core. jenkinsci/email-ext-plugin#431 provides more details on the issue --------- Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix assertions for configure system page on 2.395
Jenkins 2.395 includes jenkinsci/jenkins#7661 that simplifies the names of the settings on the "Configure System" page.
That simplification breaks email-ext tests in the Jenkins plugin bill of materials and any time they are run with Jenkins 2.395 or later. We can temporarily exclude the tests from the plugin bill of materials, but it is much better to have the tests pass.
This pull request adapts the tests to the change so that they pass with the current weekly and past LTS releases.
jenkinsci/bom#1857 shows the failing tests with Jenkins 2.395.
The failures can also be seen with the command: