Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unicode left single quotation by Ascii single quote #473

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

Bananeweizen
Copy link
Contributor

Use Ascii single quotes on both sides of the user name. Jenkins core uses the unicode character in several places, but this plugin generally doesn't.
See line 226 for the finishing quote character.

Testing done

None

Submitter checklist

Preview Give feedback

Use Ascii single quotes on both sides of the user name. Jenkins core
uses the unicode character in several places, but this plugin generally
doesn't.
@Bananeweizen Bananeweizen requested a review from a team as a code owner July 27, 2023 06:43
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slide slide merged commit 55a1037 into jenkinsci:master Apr 2, 2024
16 checks passed
@Bananeweizen Bananeweizen deleted the unicode_quote branch April 3, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants