Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML formatted email not showing up at all in Gmail #478

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

satyakommula96
Copy link
Contributor

@satyakommula96 satyakommula96 commented Aug 22, 2023

The email was not coming in the default expected template format as Gmail no longer supports the Style tag.

Testing done

Done

Submitter checklist

Preview Give feedback

@satyakommula96 satyakommula96 requested a review from a team as a code owner August 22, 2023 13:32
@basil
Copy link
Member

basil commented Aug 22, 2023

The Testing Done section is mandatory, not optional.

@basil
Copy link
Member

basil commented Aug 22, 2023

I am not willing to merge a pull request whose Testing Done section reads "None"

@satyakommula96
Copy link
Contributor Author

@basil ran test suite attached log for refrence

[INFO]
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
Running tests for org.jenkins-ci.plugins:email-ext:2.101-SNAPSHOT
[INFO] Running InjectedTest
[INFO] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.03 s -- in InjectedTest
[INFO] Running hudson.plugins.emailext.AttachmentUtilsTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.93 s -- in hudson.plugins.emailext.AttachmentUtilsTest
[INFO] Running hudson.plugins.emailext.ConfigFileMigrationTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.901 s -- in hudson.plugins.emailext.ConfigFileMigrationTest
[INFO] Running hudson.plugins.emailext.EmailExtStepTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.34 s -- in hudson.plugins.emailext.EmailExtStepTest
[INFO] Running hudson.plugins.emailext.EmailTypeTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.40 s -- in hudson.plugins.emailext.EmailTypeTest
[INFO] Running hudson.plugins.emailext.ExtendedEmailPublisherDescriptorJCasCTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.72 s -- in hudson.plugins.emailext.ExtendedEmailPublisherDescriptorJCasCTest
[INFO] Running hudson.plugins.emailext.ExtendedEmailPublisherDescriptorTest
[INFO] Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 202.0 s -- in hudson.plugins.emailext.ExtendedEmailPublisherDescriptorTest
[INFO] Running hudson.plugins.emailext.ExtendedEmailPublisherMatrixTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.55 s -- in hudson.plugins.emailext.ExtendedEmailPublisherMatrixTest
[INFO] Running hudson.plugins.emailext.ExtendedEmailPublisherTest
[INFO] Tests run: 55, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 66.95 s -- in hudson.plugins.emailext.ExtendedEmailPublisherTest
[INFO] Running hudson.plugins.emailext.MailAccountTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.89 s -- in hudson.plugins.emailext.MailAccountTest
[INFO] Running hudson.plugins.emailext.RecipientListStringAnalyserTest
[INFO] Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 s -- in hudson.plugins.emailext.RecipientListStringAnalyserTest
[INFO] Running hudson.plugins.emailext.groovy.sandbox.ObjectInstanceWhitelistTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.094 s -- in hudson.plugins.emailext.groovy.sandbox.ObjectInstanceWhitelistTest
[INFO] Running hudson.plugins.emailext.plugins.ContentBuilderTest
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 37.06 s -- in hudson.plugins.emailext.plugins.ContentBuilderTest
[INFO] Running hudson.plugins.emailext.plugins.CssInlinerTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.199 s -- in hudson.plugins.emailext.plugins.CssInlinerTest
[INFO] Running hudson.plugins.emailext.plugins.OnlyRegressionsTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.514 s -- in hudson.plugins.emailext.plugins.OnlyRegressionsTest
[INFO] Running hudson.plugins.emailext.plugins.RecipientProviderTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.00 s -- in hudson.plugins.emailext.plugins.RecipientProviderTest
[INFO] Running hudson.plugins.emailext.plugins.ZipDataSourceTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.066 s -- in hudson.plugins.emailext.plugins.ZipDataSourceTest
[INFO] Running hudson.plugins.emailext.plugins.content.FailedTestsContentTest
[INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.643 s -- in hudson.plugins.emailext.plugins.content.FailedTestsContentTest
[INFO] Running hudson.plugins.emailext.plugins.content.JellyScriptContentTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.35 s -- in hudson.plugins.emailext.plugins.content.JellyScriptContentTest
[INFO] Running hudson.plugins.emailext.plugins.content.ScriptContentBuildWrapperTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.342 s -- in hudson.plugins.emailext.plugins.content.ScriptContentBuildWrapperTest
[INFO] Running hudson.plugins.emailext.plugins.content.ScriptContentSecureTest
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 54.51 s -- in hudson.plugins.emailext.plugins.content.ScriptContentSecureTest
[INFO] Running hudson.plugins.emailext.plugins.content.ScriptContentTest
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.38 s -- in hudson.plugins.emailext.plugins.content.ScriptContentTest
[INFO] Running hudson.plugins.emailext.plugins.content.TestCountsContentTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.186 s -- in hudson.plugins.emailext.plugins.content.TestCountsContentTest
[INFO] Running hudson.plugins.emailext.plugins.content.TriggerNameContentTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.893 s -- in hudson.plugins.emailext.plugins.content.TriggerNameContentTest
[INFO] Running hudson.plugins.emailext.plugins.recipients.ContributorMetadataRecipientProviderTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.04 s -- in hudson.plugins.emailext.plugins.recipients.ContributorMetadataRecipientProviderTest
[INFO] Running hudson.plugins.emailext.plugins.recipients.CulpritsRecipientProviderTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.165 s -- in hudson.plugins.emailext.plugins.recipients.CulpritsRecipientProviderTest
[INFO] Running hudson.plugins.emailext.plugins.recipients.DevelopersRecipientProviderTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.351 s -- in hudson.plugins.emailext.plugins.recipients.DevelopersRecipientProviderTest
[INFO] Running hudson.plugins.emailext.plugins.recipients.FailingTestSuspectsRecipientProviderTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.403 s -- in hudson.plugins.emailext.plugins.recipients.FailingTestSuspectsRecipientProviderTest
[INFO] Running hudson.plugins.emailext.plugins.recipients.FirstFailingBuildSuspectsRecipientProviderTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.280 s -- in hudson.plugins.emailext.plugins.recipients.FirstFailingBuildSuspectsRecipientProviderTest
[INFO] Running hudson.plugins.emailext.plugins.recipients.PreviousRecipientProviderTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.199 s -- in hudson.plugins.emailext.plugins.recipients.PreviousRecipientProviderTest
[INFO] Running hudson.plugins.emailext.plugins.recipients.RecipientProviderUtilitiesTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.129 s -- in hudson.plugins.emailext.plugins.recipients.RecipientProviderUtilitiesTest
[INFO] Running hudson.plugins.emailext.plugins.recipients.UpstreamComitterRecipientProviderTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.023 s -- in hudson.plugins.emailext.plugins.recipients.UpstreamComitterRecipientProviderTest
[INFO] Running hudson.plugins.emailext.plugins.trigger.AbstractScriptTriggerTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.08 s -- in hudson.plugins.emailext.plugins.trigger.AbstractScriptTriggerTest
[INFO] Running hudson.plugins.emailext.plugins.trigger.BuildingTriggerTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.006 s -- in hudson.plugins.emailext.plugins.trigger.BuildingTriggerTest
[INFO] Running hudson.plugins.emailext.plugins.trigger.FirstFailureTriggerTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.945 s -- in hudson.plugins.emailext.plugins.trigger.FirstFailureTriggerTest
[INFO] Running hudson.plugins.emailext.plugins.trigger.FirstUnstableTriggerTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.001 s -- in hudson.plugins.emailext.plugins.trigger.FirstUnstableTriggerTest
[INFO] Running hudson.plugins.emailext.plugins.trigger.SecondFailureTriggerTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.980 s -- in hudson.plugins.emailext.plugins.trigger.SecondFailureTriggerTest
[INFO] Running hudson.plugins.emailext.plugins.trigger.StatusChangedTriggerTest
[INFO] Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.031 s -- in hudson.plugins.emailext.plugins.trigger.StatusChangedTriggerTest
[INFO] Running hudson.plugins.emailext.plugins.trigger.XNthFailureTriggerJTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.75 s -- in hudson.plugins.emailext.plugins.trigger.XNthFailureTriggerJTest
[INFO] Running hudson.plugins.emailext.plugins.trigger.XNthFailureTriggerTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.044 s -- in hudson.plugins.emailext.plugins.trigger.XNthFailureTriggerTest
[INFO] Running hudson.plugins.emailext.recipients.EmailRecipientUtilsTest
[INFO] Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 62.65 s -- in hudson.plugins.emailext.recipients.EmailRecipientUtilsTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 338, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  18:57 min
[INFO] Finished at: 2023-08-23T21:04:49+05:30
[INFO] ------------------------------------------------------------------------

@basil
Copy link
Member

basil commented Aug 23, 2023

That doesn't demonstrate that this change has the desired effect within Gmail.

@satyakommula96
Copy link
Contributor Author

satyakommula96 commented Aug 23, 2023

@basil
using default groovy template
without_change

with my current diff
with_chnage

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit d5d405b into jenkinsci:master Aug 23, 2023
@satyakommula96 satyakommula96 deleted the gmail_template branch August 23, 2023 17:33
@satyakommula96
Copy link
Contributor Author

@basil thanks for accepting PR

I'd like to ask how to submit environment variables or job parameters in a Groovy template. If possible, an example would greatly assist me in understanding. Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants