Do not submit an empty pre/post-send script for approval #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlatombe
approved these changes
May 13, 2024
|
I would appreciate a release when you get a moment BTW! |
|
(That would be automatic if an appropriate label were applied prior to merge.) |
|
@slide could this be released please? |
In progress now, sorry, I should have done that sooner. |
|
https://github.com/jenkinsci/email-ext-plugin/releases/tag/1814.v404722f34263 thanks! If you apply labels like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses what seems to have been a regression from 04efc23: every time you save the global config page, a warning pops up in Manage that you have a script to approve…but it is empty. Note that the method call here is deprecated as of jenkinsci/script-security-plugin@f4c0bb9 but I am not touching that.