Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent watching from applying to all jobs #561

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

slide
Copy link
Member

@slide slide commented Nov 13, 2024

Fixes the watching feature so that when a user watches a given job, it only applies to that job. Previously, when a job was watched, the project was not stored in the user property, so it would end up watching all jobs.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@slide slide added the bug label Nov 13, 2024
@slide slide requested a review from a team as a code owner November 13, 2024 00:05
Fixes the watching feature so that when a user watches
a given job, it only applies to that job. Previously,
when a job was watched, the project was not stored in
the user property, so it would end up watching all jobs.
@slide slide merged commit d9e491c into jenkinsci:main Nov 13, 2024
17 checks passed
@slide slide deleted the watching_fix branch November 13, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant