Reduce the use of reflection in some rare circumstances #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very slightly mitigates the impact of JENKINS-60891 in two rather rare circumstances: when the environment is not changing, and when an existing variable is being updated. This is far from a solution to JENKINS-60891, but at least it's better than nothing. A full solution would require core changes and adaptations in several other plugins, which would be a much larger effort. Meanwhile, this can't hurt and is better than the status quo.
Testing done
Manually tested that overriding the
PATHparameter failed before this PR and succeeded after this PR on Java 17.