Add junit test for set-external-build-result CLI command #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump parent pom version to 1.511. We need even higher to get CLICommandInvoker class for granted. However, since parent pom 1.512 version both legacy and new unit test frameworks are broken: TopLevelItemDescriptor can not be retrieved any more. As a work around copy temporary CLICommandInvoker in our test and remove it once the problem with unit test framework is ssolved.
|
Jenkins » external-monitor-job-plugin #19 UNSTABLE |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Follow-up to #5. Currently do not have time to review. |
|
What exactly was the problem with the test harness? Is it filed/solved? Have you checked with the current parent POM, 1.532.1? |
|
@jglick |
|
Deserves a merge with |
|
Test does not pass and has a variety of issues blocking it from working. Not going to spend time fixing up the current PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump parent pom version to 1.511. We need even higher to get CLICommandInvoker
class for granted. However, since parent pom 1.512 version both legacy and new
unit test frameworks are broken: TopLevelItemDescriptor can not be retrieved
any more. As a work around copy temporary CLICommandInvoker in our test and
remove it once the problem with unit test framework is ssolved.