Skip to content

Commit

Permalink
Merge pull request #447 from jenkinsci/symbols
Browse files Browse the repository at this point in the history
Replace icons with symbols
  • Loading branch information
uhafner authored Sep 21, 2022
2 parents 8cdc3a5 + 9b1cfb5 commit c4e5d08
Show file tree
Hide file tree
Showing 11 changed files with 11 additions and 25 deletions.
4 changes: 4 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@

<module.name>${project.groupId}.forensics.api</module.name>

<jenkins.baseline>2.346</jenkins.baseline>
<jenkins.version>2.346.3</jenkins.version>

<!-- Library Dependencies Versions -->
<eclipse-collections.version>9.2.0</eclipse-collections.version>
<testcontainers.version>1.17.3</testcontainers.version>
Expand Down Expand Up @@ -55,6 +58,7 @@
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>font-awesome-api</artifactId>
<version>6.2.0-1</version>
</dependency>
<dependency>
<groupId>io.jenkins.plugins</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ protected String getBuildResultBaseName() {

@Override
public String getIconFileName() {
return ForensicsJobAction.SMALL_ICON;
return ForensicsJobAction.ICON;
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
* @author Ullrich Hafner
*/
public class ForensicsJobAction extends AsyncConfigurableTrendJobAction<ForensicsBuildAction> {
static final String SMALL_ICON = "/plugin/forensics-api/icons/forensics.svg";
static final String ICON = "symbol-solid/microscope plugin-font-awesome-api";
static final String FORENSICS_ID = "forensics";
private static final JacksonFacade JACKSON_FACADE = new JacksonFacade();

Expand Down Expand Up @@ -96,7 +96,7 @@ public String getDisplayName() {
@Override
@CheckForNull
public String getIconFileName() {
return SMALL_ICON;
return ICON;
}

@Override
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/images/symbols/diff-stat.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:t="/lib/hudson">

<t:summary icon="/plugin/forensics-api/icons/diff-stat.svg">
<t:summary icon="symbol-diff-stat plugin-forensics-api">
<span id="commits-statistics-of-${it.scmKey.hashCode()}">
${%title}: ${it.scmKey}
<j:set var="s" value="${it.commitStatistics}"/>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:t="/lib/hudson">

<t:summary icon="/plugin/forensics-api/icons/forensics.svg">
<t:summary icon="symbol-solid/microscope plugin-font-awesome-api">
<span id="scm-forensics-of-${it.scmKey.hashCode()}">
${%title}: ${it.scmKey}
<j:set var="s" value="${it.result.latestStatistics}"/>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:t="/lib/hudson" xmlns:fa="/font-awesome">

<t:summary icon="/plugin/forensics-api/icons/crosshair.svg">
<t:summary icon="symbol-locate plugin-ionicons-api">
<span id="reference-build">
<j:choose>
<j:when test="${it.hasReferenceBuild()}">
Expand Down
4 changes: 0 additions & 4 deletions src/main/webapp/icons/LICENSE.txt

This file was deleted.

3 changes: 0 additions & 3 deletions src/main/webapp/icons/crosshair.svg

This file was deleted.

9 changes: 0 additions & 9 deletions src/main/webapp/icons/diff-stat.svg

This file was deleted.

3 changes: 0 additions & 3 deletions src/main/webapp/icons/forensics.svg

This file was deleted.

0 comments on commit c4e5d08

Please sign in to comment.