Add a 3 second delay to decrease failures in the threaded submodule test #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
changed the title
jtnord
reviewed
Jun 18, 2024
| @@ -77,7 +77,7 @@ public void testSubmoduleUpdateWithThreads() throws Exception { | |||
| .execute(); | |||
| w.git.submoduleInit(); | |||
| w.git.submoduleUpdate().threads(3).execute(); | |||
|
|
|||
| Thread.sleep(3000); | |||
There was a problem hiding this comment.
given execute() does not return a Future and GitCommands can take a timeout, shouldn't this be method be considered synchronous?
As such wouldn't this be a production issue and not a test issue?
There was a problem hiding this comment.
I'm not willing at this point to spend the time to investigate if the method is synchronous. I had never seen this test fail in my tests on ci.jenkins.io or in my home lab, but it was a harmless addition, so I accepted it. Will propose a revert to tidy the test a little.
There was a problem hiding this comment.
Submitted as:
MarkEWaite
added a commit
to MarkEWaite/git-client-plugin
that referenced
this pull request
Jun 18, 2024
jenkinsci#1122 (comment) notes that the sleep does not actually help the test other than to delay its completion. This reverts commit fb9d2ca.
9 tasks
MarkEWaite
added a commit
that referenced
this pull request
Jun 18, 2024
#1122 (comment) notes that the sleep does not actually help the test other than to delay its completion. This reverts commit fb9d2ca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEE-47337
The test case is failing at the assertion and clearly its the problem at Threads, where in the submoduleUpdate has not been completed yet and its proceeding to the assertions, adding a slight delay will make sure the submoduleupdate is complete.
Checklist
Types of changes
What types of changes does your code introduce?