Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last references to JUnit 3 #1146

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Jun 9, 2024

Remove last references to JUnit 3

JUnit 3 usage was removed from the git client plugin test suite a year or two ago. No need to mention it in comments.

Use the same test skipping technique as is used in the git plugin. The warnings plugin reports a warning for each test that is not executed due to an assumeThat() condition. I don't consider these cases worthy of a warning because it is intentional that the test is not executed.

Also adds TODO items for symref conditional removal once the plugin no longer runs tests on RHEL 7 or its derivatives.

I confirmed that the test execution changes pass on my Linux and my Windows computers. Will rely on ci.jenkins.io to confirm that the test change also passes there.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

What types of changes does your code introduce?

  • Test improvements and code comments

Command line git 1.8 (as included in RHEL 7, CentOS 7, and others)
does not include symref functionality.  The symref feature was added in
command line git 2.8.  Command line git 2.11 or newer is standard with
all operating systems currently supported by Jenkins.  When the git
client plugin is ready to drop support for RHEL 7, these conditionals
can be removed.
@MarkEWaite MarkEWaite added the tests Automated test addition or improvement label Jun 9, 2024
@MarkEWaite MarkEWaite requested a review from a team as a code owner June 9, 2024 13:44
JUnit 3 usage was removed from the git client plugin test suite a year
or two ago.  No need to mention it in comments.

Use the same test skipping test as is used in the git plugin.  The
warnings plugin reports a warning for each test that is not executed
due to an assumeThat() condition.  I don't consider these cases worthy
of a warning because it is intentional that the test is not executed.
@MarkEWaite MarkEWaite merged commit 4f1d4a4 into jenkinsci:master Jun 11, 2024
15 checks passed
@MarkEWaite MarkEWaite deleted the remove-junit-3-comment branch June 11, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant