Remove last references to JUnit 3 #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command line git 1.8 (as included in RHEL 7, CentOS 7, and others) does not include symref functionality. The symref feature was added in command line git 2.8. Command line git 2.11 or newer is standard with all operating systems currently supported by Jenkins. When the git client plugin is ready to drop support for RHEL 7, these conditionals can be removed.
JUnit 3 usage was removed from the git client plugin test suite a year or two ago. No need to mention it in comments. Use the same test skipping test as is used in the git plugin. The warnings plugin reports a warning for each test that is not executed due to an assumeThat() condition. I don't consider these cases worthy of a warning because it is intentional that the test is not executed.
MarkEWaite
force-pushed
the
remove-junit-3-comment
branch
from
464f3f7
to
57eb052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove last references to JUnit 3
JUnit 3 usage was removed from the git client plugin test suite a year or two ago. No need to mention it in comments.
Use the same test skipping technique as is used in the git plugin. The warnings plugin reports a warning for each test that is not executed due to an assumeThat() condition. I don't consider these cases worthy of a warning because it is intentional that the test is not executed.
Also adds TODO items for symref conditional removal once the plugin no longer runs tests on RHEL 7 or its derivatives.
I confirmed that the test execution changes pass on my Linux and my Windows computers. Will rely on ci.jenkins.io to confirm that the test change also passes there.
Checklist
Types of changes
What types of changes does your code introduce?