Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated tests #1147

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Conversation

MarkEWaite
Copy link
Contributor

Remove outdated tests

The git client plugin no longer needs to support command line git older than 2.11 because all the operating systems supoprted by Jenkins include command line git 2.11 or newer. No need for conditionals to check for older versions.

The command line git versions supported by the git client plugin all include symref functionality. No need to test for support of symref, since all supported versions of command line git include it.

https://www.jenkins.io/blog/2023/05/30/operating-system-end-of-life/ is the May 2023 blog post that announced the end of life for RHEL 7 and its derivatives.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

What types of changes does your code introduce?

  • Tests

Red Hat Enterprise Linux 7 includes command line git 1.8.  No other
supported operating system includes a command line git version older
than 2.20.

Debian 10 is the oldest command line git version on a supported operating
system with command line git 2.20.  Ubuntu 20 has a newer command line
git version.
All supported versions of command line git include symref support so
there is no need for conditionals that check for symref support before
running the tests.
@MarkEWaite MarkEWaite requested a review from a team as a code owner June 14, 2024 17:56
@MarkEWaite MarkEWaite added the tests Automated test addition or improvement label Jun 14, 2024
@MarkEWaite MarkEWaite merged commit f988d25 into jenkinsci:master Jun 15, 2024
15 checks passed
@MarkEWaite MarkEWaite deleted the remove-old-git-tests branch June 15, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant