Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare API's that throw GitException #1166

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Declare API's that throw GitException #1166

merged 1 commit into from
Aug 7, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 6, 2024

I noticed that methods were not consistently marked as throwing GitException even when they in fact could. Fixed by temporarily making this extend Exception rather than RuntimeException and then fixing resulting compiler errors.

@jglick jglick requested a review from a team as a code owner August 6, 2024 21:27
@github-actions github-actions bot added the tests Automated test addition or improvement label Aug 6, 2024
@jglick jglick mentioned this pull request Aug 6, 2024
Merged
MarkEWaite
MarkEWaite approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. I want to run it in plugin BOM with the weekly test to assure that there are no surprises detected there.

@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Aug 6, 2024
MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Aug 6, 2024
@MarkEWaite
Test git client plugin GitException improvements
d30408d 
jenkinsci/git-client-plugin#1166 improves
the consistency of GitException use in the git client plugin method
declarations.
@MarkEWaite MarkEWaite mentioned this pull request Aug 6, 2024
Closed
@MarkEWaite MarkEWaite added bug Incorrect or flawed behavior and removed chore Reduces maintenance effort by changes not directly visible to users tests Automated test addition or improvement labels Aug 6, 2024
@MarkEWaite MarkEWaite changed the title Consistent treatment of GitException Declare API's that report GitException Aug 6, 2024
@MarkEWaite MarkEWaite changed the title Declare API's that report GitException Declare API's that throw GitException Aug 6, 2024
@MarkEWaite MarkEWaite merged commit 6836720 into jenkinsci:master Aug 7, 2024
17 checks passed
@jglick jglick deleted the GitException branch August 7, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
bug Incorrect or flawed behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @MarkEWaite