Allow tests from shallow clone repos #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not attempt to use the local repository as a reference repository when the local repository is a shallow clone. A shallow clone repository has no content to offer as a reference. Fixes 64 test failures when the test repository is a shallow clone. jenkinsci/bom#1613 describes the experiment to run the plugin compatibility tests with shallow clones. jenkinsci/git-plugin#1365 implemented a similar change in the git plugin so that shallow cloned repositories will not fail the tests in that plugin. Will make a few tests in a shallow repository a little slower because they will require a full clone of the git client plugin repository rather than reusing the existing clone in the test workspace. Doubtful that the performance difference will be detectable within the general variability of CI test jobs.
6 tasks
jglick
reviewed
Dec 13, 2022
| @@ -372,7 +377,13 @@ protected String localMirror() throws IOException, InterruptedException { | |||
| * the final destination directory. | |||
| */ | |||
| Path tempClonePath = Files.createTempDirectory(targetDir.toPath(), "clone-"); | |||
| w.launchCommand("git", "clone", "--reference", f.getCanonicalPath(), "--mirror", "https://github.com/jenkinsci/git-client-plugin", tempClonePath.toFile().getAbsolutePath()); | |||
| String repoUrl = "https://github.com/jenkinsci/git-client-plugin.git"; | |||
There was a problem hiding this comment.
Fine as a hotfix, but jenkinsci/git-plugin#1365 (review)
MarkEWaite
added a commit
that referenced
this pull request
Dec 13, 2022
Do not attempt to use the local repository as a reference repository when the local repository is a shallow clone. A shallow clone repository has no content to offer as a reference. Fixes 64 test failures when the test repository is a shallow clone. jenkinsci/bom#1613 describes the experiment to run the plugin compatibility tests with shallow clones. jenkinsci/git-plugin#1365 implemented a similar change in the git plugin so that shallow cloned repositories will not fail the tests in that plugin. Will make a few tests in a shallow repository a little slower because they will require a full clone of the git client plugin repository rather than reusing the existing clone in the test workspace. Doubtful that the performance difference will be detectable within the general variability of CI test jobs. (cherry picked from commit 5c98434)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow tests from shallow cloned repositories
Do not attempt to use the local repository as a reference repository when the local repository is a shallow clone. A shallow clone repository has no content to offer as a reference. Fixes 64 test failures when the test repository is a shallow clone.
jenkinsci/bom#1613 describes the experiment to run the plugin compatibility tests with shallow clones.
jenkinsci/git-plugin#1365 implemented a similar change in the git plugin so that shallow cloned repositories will not fail the tests in that plugin.
Will make a few tests in a shallow repository a little slower because they will require a full clone of the git client plugin repository rather than reusing the existing clone in the test workspace. Doubtful that the performance difference will be detectable within the general variability of CI test jobs.
Checklist
Types of changes