Skip to content

Commit

Permalink
Fix acceptance tests bny reverting capitalization change (#1647)
Browse files Browse the repository at this point in the history
The Jenkins acceptance test harness uses the display name to locate UI
components and test them.  It locates those components by display name.

The tests in the acceptance test harness are especially valuable now while
we are preparing for the Spring Security 6.x upgrade.  It is better to
retain the previous capitalization and preserve Jenkins acceptance test
harness results rather than need to spread the capitalization change
into the acceptance test harness and related components.

Added TODO item to fix the capitalization in both the git plugin and
the acceptance test harness in a future release.
  • Loading branch information
MarkEWaite authored Aug 26, 2024
1 parent fea4aad commit 020e072
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,13 @@ public void determineSupportForJGit(GitSCM scm, @NonNull UnsupportedCommand cmd)
public static class DescriptorImpl extends GitSCMExtensionDescriptor {
@Override
public String getDisplayName() {
return "Sparse checkout paths";
/* TODO Fix capitalization error here and in Jenkins acceptance test harness.

Check warning on line 60 in src/main/java/hudson/plugins/git/extensions/impl/SparseCheckoutPaths.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO

NORMAL: Fix capitalization error here and in Jenkins acceptance test harness.
*
* https://github.com/jenkinsci/acceptance-test-harness/pull/1685#issuecomment-2310075738
* Acceptance test harness for Git SCM should find components by class instead of by
* display name. Otherwise changes to display name need to be made in ATH and the plugin.
*/
return "Sparse Checkout paths";
}
}

Expand Down

0 comments on commit 020e072

Please sign in to comment.