fix: Correct quoting in GitUsernamePasswordBinding
#1314
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-27082 - Quote the username and password in credentials binding
Followup an better solution to: #1310
Fix wrong quoting in askpass.
Won't solve all cases of quoting but will avoid some common problems related to quoting. For example, if the username or password includes a single quote, then the added quoting will fail. For the more common cases where the username or password contains a special special character that is not a single quote, this pull request will be an improvement.
Checklist
Types of changes
Correct quoting in bash script.