Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add archived filter (JENKINS-64353) #27

Merged
merged 7 commits into from
Nov 1, 2021
Merged

feat: add archived filter (JENKINS-64353) #27

merged 7 commits into from
Nov 1, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Jan 30, 2021 •
edited
Loading

This is required by me and inspired by jenkinsci/github-branch-source-plugin#274

fixes JENKINS-64353

@viceice viceice changed the title feat: add archived filter feat: add archieved filter Jan 30, 2021
@viceice viceice changed the title feat: add archieved filter feat: add archived filter Jan 30, 2021
@viceice
Copy link
Member Author

viceice commented Jan 31, 2021

Need some help for tests

@viceice viceice changed the title feat: add archived filter feat: add archived filter (JENKINS-64353) Jan 31, 2021
@viceice viceice marked this pull request as ready for review March 8, 2021 11:47
@justusbunsi
Copy link
Member

Need some help for tests

Do you need help testing this feature in a Jenkins environment or with writing tests?

@viceice
Copy link
Member Author

viceice commented May 8, 2021

Help for writing tests, this is already working fine in our company.

@justusbunsi
Copy link
Member

Unfortunately my current Java knowledge is not enough to help you on that part, sorry.

@lafriks lafriks added this to the 1.4.0 milestone Oct 27, 2021
@viceice
Copy link
Member Author

viceice commented Oct 27, 2021

@lafriks Updated pr and fixed test, ready to review

justusbunsi
justusbunsi reviewed Oct 31, 2021
View reviewed changes
Copy link
Member

@justusbunsi justusbunsi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature. From a functional point of view this PR is good to go. The only thing I'm not sure about is the copyright year below.

src/main/java/org/jenkinsci/plugin/gitea/ExcludeArchivedRepositoriesTrait.java Outdated Show resolved Hide resolved
@justusbunsi
Copy link
Member

Do you mind to update to match the current main branch so that it can properly be merged?

@viceice
Copy link
Member Author

viceice commented Nov 1, 2021

done

@justusbunsi justusbunsi merged commit 8c9922c into jenkinsci:master Nov 1, 2021
@viceice viceice deleted the feat/repo-filter branch November 2, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusbunsi justusbunsi justusbunsi approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@viceice @justusbunsi @lafriks