Dependency updates #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
justusbunsi
commented
Nov 6, 2021
justusbunsi
commented
- Bump Jenkins version according to Recommended Jenkins minimum version
- Fix build error regarding entropy class
- Configure build properties
- Bump Jenkins version according to https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ - Fix build error regarding entropy class - Configure build properties
justusbunsi
commented
Nov 6, 2021
| <argLine>-Dfile.encoding=${project.build.sourceEncoding}</argLine> | ||
| <jenkins.version>2.289.1</jenkins.version> | ||
| <spotbugs.effort>Max</spotbugs.effort> | ||
| <spotbugs.failOnError>true</spotbugs.failOnError> |
There was a problem hiding this comment.
The default build parameters seem to just ignore possible bugs spotted. Hopefully this will break the build in such case.
|
Should we add Dependabot to keep the dependencies up-to-date? I have the feeling, doing this manually is not going well. There are some dependencies getting updated quite often. |
lafriks
approved these changes
Nov 7, 2021
|
Yes, we should probably add dependabot |
|
better use renovate 😛 |
You are absolutely right. Renovate is great. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.